Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

draft e2e test #219

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

draft e2e test #219

wants to merge 2 commits into from

Commits on Jun 6, 2022

  1. Correctly connect parties with socket. (facebookresearch#218) 

    Summary:
Pull Request resolved: facebookresearch#218

Our existing arrangement of party info (ip address and port number) is buggy as there will be a conflict with more than 2 parties. This diff is to address this issue.

Our current code works fine with 2 party setting. But it will break with more than 2 parties.

Example scenario:
when party 0 connects with party 1, with current code, he will pull out the partyinfo of party 0, and add one to the port number. Party 1 will add 1 to a port number on his side.
When party 1 connects with party 2, with current code, he will pull out the same partyinfo of party 0, and add on to the port number. Party 2 will add 1 to a port number on his side.

Since multiple connections will be established between each pair of parties, this will definitely create a conflict. For example, party 0 will add 1 to the same port number twice while others only do that once.

Our solution:

1. Each party keep a map of partyinfo, served as "info needed to connected to party i".
2. during each connection attemption, each party will use the peer's id to look up the partyinfo map. If this party is going to play the role of server, the ip address is useless. The corresponding ip address and port number can be used to establish connection.

Differential Revision: D36908724

fbshipit-source-id: 60c96c97f2cc1c77710ad55ebda63c179abd14ca
    @RuiyuZhu @facebook-github-bot
    RuiyuZhu authored and facebook-github-bot committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    1edd51e View commit details
    Browse the repository at this point in the history

  2. draft e2e test 

    Differential Revision: D36870515

fbshipit-source-id: bf26401c5d26a870ff736aade6d6346127ffe92d
    @adshastri @facebook-github-bot
    adshastri authored and facebook-github-bot committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    c6c789e View commit details
    Browse the repository at this point in the history