Update PyTorch THPVariable_Wrap to use const ref #843
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? Please describe:
This comes from a change from PyTorch pytorch/pytorch#138880 in which the signature of
THPVariable_Wrap
changes toA build failure happens when importing the change to fbcode D65031075 for one project that is using
fairseq2
Does your PR introduce any breaking changes? If yes, please list them:
This makes fairseq2 compatible with latest PyTorch, so I don't think there is any breaking change here.
Check list: