Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor wav2vec2 masker #830

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Refactor wav2vec2 masker #830

wants to merge 1 commit into from

Conversation

cbalioglu
Copy link
Contributor

This PR:

  • Introduces a new RowMaskFactory protocol which compute_row_mask follows.
  • Converts Wav2Vec2Masker into an interface and moves its existing implementation to a new StandardWav2Vec2Masker.
  • Introduces a new mask_factory parameter in StandardWav2Vec2Masker to optionally override the standard compute_row_mask implementation.
  • Removes the final annotation from GumbelVectorQuantizer and GumbelVectorQuantizerOutput.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshvartsman mshvartsman Awaiting requested review from mshvartsman

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbalioglu @facebook-github-bot