Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise third-party builds #203

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Revise third-party builds #203

merged 2 commits into from
Dec 11, 2023

Conversation

cbalioglu
Copy link
Contributor

@cbalioglu cbalioglu commented Dec 10, 2023

This PR revises the handling of third-party lib builds for fairseq2n including migrating to static libjpeg-turbo and libpng. It also temporarily disables JPEG decoding tests due to a segfault on Macs and DataPipeline sampling tests due to issues with RNG on Macs.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 10, 2023
@cbalioglu cbalioglu changed the title Use static libjpeg and libpng Use third-party builds Dec 11, 2023
@cbalioglu cbalioglu changed the title Use third-party builds Revise third-party builds Dec 11, 2023
@cbalioglu cbalioglu marked this pull request as ready for review December 11, 2023 03:47
@cbalioglu cbalioglu merged commit 0902ef1 into main Dec 11, 2023
19 checks passed
@cbalioglu cbalioglu deleted the png branch December 11, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants