feat: Add option to negate bits written to ByteOutputStream #12050
+81
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: In PrestoSerializer we write the null bits to a ByteOutputStream. Presto's serialization format inverts the null flags from what Velox uses. This change adds an option to ByteOutputStream to do that negation on flush, rather than requiring the user to negate them when calling append. This makes it easier to write ranges of null bits without an additional copy, and reduces the level of mental gymnastics needed to reason about the null flags in the serializer. (It's analogous to the option ByteOutputStream already has to reverse the order of bits within a byte, again because of Presto's serialization format for null flags). Differential Revision: D67994045
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67994045 |
✅ Deploy Preview for meta-velox canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In PrestoSerializer we write the null bits to a ByteOutputStream. Presto's serialization format inverts the null
flags from what Velox uses. This change adds an option to ByteOutputStream to do that negation on flush,
rather than requiring the user to negate them when calling append. This makes it easier to write ranges of null
bits without an additional copy, and reduces the level of mental gymnastics needed to reason about the null
flags in the serializer. (It's analogous to the option ByteOutputStream already has to reverse the order
of bits within a byte, again because of Presto's serialization format for null flags).
Differential Revision: D67994045