feat(fuzzer): Update makeAlternatePlans to generate multi-join plans #11942
+1,031
−889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D67607654 |
DanielHunte
force-pushed
the
export-D67607654
branch
from
f81d6de to
751e6c8
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 23, 2024
…acebookincubator#11942) Summary: Change makeAlternatePlans functions to produce cascading multi-joins. Differential Revision: D67607654
|
This pull request was exported from Phabricator. Differential Revision: D67607654 |
DanielHunte
force-pushed
the
export-D67607654
branch
from
751e6c8 to
a4e2de7
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 27, 2024
…acebookincubator#11942) Summary: Change makeAlternatePlans functions to produce cascading multi-joins. Differential Revision: D67607654
|
This pull request was exported from Phabricator. Differential Revision: D67607654 |
DanielHunte
force-pushed
the
export-D67607654
branch
from
a4e2de7 to
d67e5fb
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 27, 2024
…acebookincubator#11942) Summary: Change makeAlternatePlans functions to produce cascading multi-joins. Differential Revision: D67607654
|
This pull request was exported from Phabricator. Differential Revision: D67607654 |
DanielHunte
force-pushed
the
export-D67607654
branch
from
d67e5fb to
ed95027
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 27, 2024
…acebookincubator#11942) Summary: Change makeAlternatePlans functions to produce cascading multi-joins. Differential Revision: D67607654
|
This pull request was exported from Phabricator. Differential Revision: D67607654 |
DanielHunte
force-pushed
the
export-D67607654
branch
from
ed95027 to
ea35f9c
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 30, 2024
…acebookincubator#11942) Summary: Change makeAlternatePlans functions to produce cascading multi-joins. Differential Revision: D67607654
|
This pull request was exported from Phabricator. Differential Revision: D67607654 |
DanielHunte
force-pushed
the
export-D67607654
branch
from
ea35f9c to
9dc5941
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 30, 2024
…acebookincubator#11942) Summary: Change makeAlternatePlans functions to produce cascading multi-joins. Differential Revision: D67607654
|
This pull request was exported from Phabricator. Differential Revision: D67607654 |
DanielHunte
force-pushed
the
export-D67607654
branch
from
9dc5941 to
dda9d78
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 30, 2024
…acebookincubator#11942) Summary: Change makeAlternatePlans functions to produce cascading multi-joins. Differential Revision: D67607654
|
This pull request was exported from Phabricator. Differential Revision: D67607654 |
DanielHunte
force-pushed
the
export-D67607654
branch
from
dda9d78 to
4c03bd8
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 7, 2025
…acebookincubator#11942) Summary: Change makeAlternatePlans functions to produce cascading multi-joins. Differential Revision: D67607654
|
This pull request was exported from Phabricator. Differential Revision: D67607654 |
DanielHunte
force-pushed
the
export-D67607654
branch
from
4c03bd8 to
a58acd0
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Jan 7, 2025
…acebookincubator#11942) Summary: Change makeAlternatePlans functions to produce cascading multi-joins. Differential Revision: D67607654
|
This pull request was exported from Phabricator. Differential Revision: D67607654 |
added 6 commits
January 9, 2025 16:13
… for reference query runners (facebookincubator#11801) Summary: Currently, the hash join and nested loop join "toSql" methods for all reference query runners only support a single join. This change extends it to support multiple joins, only needing the join node of the last join in the tree. It traverses up the tree and recursively builds the sql query. Differential Revision: D66977480
…ns (facebookincubator#11938) Summary: The function should traverse the plan tree and recursively flip the sides of all join nodes that are eligible to be flipped. This is in preparation to make the Join Fuzzer produce plans with multiple joins. Flipping join sides help make alternate plans that should be logically equivalent. Reviewed By: kgpai Differential Revision: D67606686
…n plans (facebookincubator#11939) Summary: Generates a cascading multi-join from left to right. ``` [t1, t2, t3, t4] t1 t2 \ / a t3 \ / b t4 \ / c ``` Differential Revision: D67607316
… plans (facebookincubator#11940) Summary: Generates a cascading multi-join from left to right with table scans as the inputs. ``` [t1, t2, t3, t4] t1 t2 \ / a t3 \ / b t4 \ / c ``` Differential Revision: D67607533
…join plans (facebookincubator#11941) Summary: Change makeMergeJoinPlan and makeNestedLoopJoinPlan functions to produce cascading multi-joins. Differential Revision: D67607605
…acebookincubator#11942) Summary: Change makeAlternatePlans functions to produce cascading multi-joins. Differential Revision: D67607654
DanielHunte
force-pushed
the
export-D67607654
branch
from
a58acd0 to
91519e0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67607654 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Change makeAlternatePlans functions to produce cascading multi-joins.
Differential Revision: D67607654