Skip to content

Commit

Permalink
Bump pypa/gh-action-pypi-publish from 1.6.4 to 1.12.2 (#11494)
Browse files Browse the repository at this point in the history
Summary:
Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.6.4 to 1.12.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/pypa/gh-action-pypi-publish/releases">pypa/gh-action-pypi-publish's releases</a>.</em></p>
<blockquote>
<h2>v1.12.2</h2>
<h2>🐛 What's Fixed</h2>
<p>The fix for signing legacy zip sdists turned out to be incomplete, so <a href="https://github.com/woodruffw"><code>@​woodruffw</code></a><a href="https://github.com/sponsors/woodruffw">💰</a> promptly produced another follow-up that updated <code>pypi-attestations</code> from v0.0.13 to v0.0.15 in <a href="https://redirect.github.com/pypa/gh-action-pypi-publish/issues/297">https://github.com/facebookincubator/velox/issues/297</a>. This is the only change since the previous release.</p>
<p><strong>🪞 Full Diff</strong>: <a href="https://github.com/pypa/gh-action-pypi-publish/compare/v1.12.1...v1.12.2">https://github.com/pypa/gh-action-pypi-publish/compare/v1.12.1...v1.12.2</a></p>
<p><strong>🧔‍♂️ Release Manager:</strong> <a href="https://github.com/sponsors/webknjaz"><code>@​webknjaz</code></a> <a href="https://stand-with-ukraine.pp.ua">🇺🇦</a></p>
<h2>v1.12.1</h2>
<h2>🐛 What's Fixed</h2>
<p>Version v1.12.0 hit several rare corner cases we never considered fully supported, and this release fixes a few of those.
In <a href="https://redirect.github.com/pypa/gh-action-pypi-publish/issues/294">https://github.com/facebookincubator/velox/issues/294</a>, <a href="https://github.com/webknjaz"><code>@​webknjaz</code></a><a href="https://github.com/sponsors/webknjaz">💰</a> improved the self-hosted runner experience by pre-installing Python if it's not there, and with <a href="https://redirect.github.com/pypa/gh-action-pypi-publish/issues/293">https://github.com/facebookincubator/velox/issues/293</a> the ability to use the action on GitHub Enterprise instances has been restored. The latter should've also fixed the ability to invoke <a href="https://github.com/marketplace/actions/pypi-publish"><code>pypi-publish</code></a> from nested in-repo composite actions — another exotic use-case that was never tested in our CI.
<a href="https://github.com/woodruffw"><code>@​woodruffw</code></a><a href="https://github.com/sponsors/woodruffw">💰</a> also managed to squeeze in a last-minute fix for detecting legacy <code>.zip</code> sdists while producing attestations via <a href="https://redirect.github.com/pypa/gh-action-pypi-publish/issues/295">https://github.com/facebookincubator/velox/issues/295</a>.</p>
<p><strong>🪞 Full Diff</strong>: <a href="https://github.com/pypa/gh-action-pypi-publish/compare/v1.12.0...v1.12.1">https://github.com/pypa/gh-action-pypi-publish/compare/v1.12.0...v1.12.1</a></p>
<p><strong>🧔‍♂️ Release Manager:</strong> <a href="https://github.com/sponsors/webknjaz"><code>@​webknjaz</code></a> <a href="https://stand-with-ukraine.pp.ua">🇺🇦</a></p>
<p><strong>🙏 Huge Thanks</strong> to all the bug reporters for posting the logs, helping inspect the problems and verify the regression fixes!</p>
<h2>v1.12.0</h2>
<h2>⚡️ Why Should You Update?</h2>
<p>This is a minor version bump, but it does not add any new user-facing interfaces. Still, I felt like it should not be a patch-release: this update brings <em>significant changes</em> to the action invocation and internal release process.</p>
<p>Previously, each invocation of <a href="https://github.com/marketplace/actions/pypi-publish"><code>pypi-publish</code></a> required building a container image in the invoking CI job. This was inefficient and added about 30 seconds to the publishing jobs at their startup just to build the container.</p>
<p>I wanted to improve this for over three years (<a href="https://redirect.github.com/pypa/gh-action-pypi-publish/issues/58">https://github.com/facebookincubator/velox/issues/58</a>) and a little over half a year ago <a href="https://github.com/br3ndonland"><code>@​br3ndonland</code></a><a href="https://github.com/sponsors/br3ndonland">💰</a> stepped up and offered a very comprehensive solution to the limitation I was hoping to overcome: <a href="https://redirect.github.com/pypa/gh-action-pypi-publish/issues/230">https://github.com/facebookincubator/velox/issues/230</a>.</p>
<p>Going forward, I'm going to pre-build per-version containers prior to cutting each release. And the action invocations will just pull the image from GitHub Container registry.</p>
<blockquote>
<p>[!CAUTION]
Known quirks:</p>
<ul>
<li>This seems to not work on self-hosted runners without a <code>python</code> executable: <a href="https://redirect.github.com/pypa/gh-action-pypi-publish/issues/289">https://github.com/facebookincubator/velox/issues/289</a>. The workaround could be installing it prior to running the action.</li>
<li><del>Pinning to commit hashes does not work: <a href="https://redirect.github.com/pypa/gh-action-pypi-publish/issues/290">https://github.com/facebookincubator/velox/issues/290</a>. Workaround: postpone updating until it's fixed or switch to Git tags for now. Subscribe to that issue to follow the progress.</del> <em>UPD:</em> This was an issue during the first 12 hours post release and it has been addressed upstream by publishing a commit SHA-tagged image for the release on Nov 12, 2024 at 10:27 UTC+1.</li>
<li>Calling <code>pypi-publish</code> from another nested repo-local composite action might be breaking file paths: <a href="https://redirect.github.com/pypa/gh-action-pypi-publish/issues/291">https://github.com/facebookincubator/velox/issues/291</a>. Workaround: postpone updating until it's fixed. Subscribe to that issue to follow the progress.</li>
<li>Running within GitHub Enterprise fails on the action repo clone: <a href="https://redirect.github.com/pypa/gh-action-pypi-publish/issues/292">https://github.com/facebookincubator/velox/issues/292</a>. Workaround: postpone updating until it's fixed. Subscribe to that issue to follow the progress.</li>
</ul>
</blockquote>
<p><strong>🪞 Full Diff</strong>: <a href="https://github.com/pypa/gh-action-pypi-publish/compare/v1.11.0...v1.12.0">https://github.com/pypa/gh-action-pypi-publish/compare/v1.11.0...v1.12.0</a></p>
<p><strong>🧔‍♂️ Release Manager:</strong> <a href="https://github.com/sponsors/webknjaz"><code>@​webknjaz 🇺🇦</code></a></p>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/pypa/gh-action-pypi-publish/commit/15c56dba361d8335944d31a2ecd17d700fc7bcbc"><code>15c56db</code></a> Merge pull request <a href="https://redirect.github.com/pypa/gh-action-pypi-publish/issues/297">https://github.com/facebookincubator/velox/issues/297</a> from trail-of-forks/ww/bump-pypi-attestations</li>
<li><a href="https://github.com/pypa/gh-action-pypi-publish/commit/fe8d1484ba76730fec68a234daa6dbe243aa2af0"><code>fe8d148</code></a> requirements: bump pypi-attestations to 0.0.15</li>
<li><a href="https://github.com/pypa/gh-action-pypi-publish/commit/1f5d4ec244f65dce93685ee3e98e77123f090866"><code>1f5d4ec</code></a> Merge pull request <a href="https://redirect.github.com/pypa/gh-action-pypi-publish/issues/295">https://github.com/facebookincubator/velox/issues/295</a> from trail-of-forks/ww/fix-sdist-collection</li>
<li><a href="https://github.com/pypa/gh-action-pypi-publish/commit/fec2f0c0cea943a654e4c65b547300a042e8af56"><code>fec2f0c</code></a> attestations: collect *.zip sdists as well</li>
<li><a href="https://github.com/pypa/gh-action-pypi-publish/commit/a8b73a6d88e1c2ae7ee7bf90b8ebba800a10f203"><code>a8b73a6</code></a> Merge pull request <a href="https://redirect.github.com/pypa/gh-action-pypi-publish/issues/294">https://github.com/facebookincubator/velox/issues/294</a> from webknjaz/bugfixes/optional-python</li>
<li><a href="https://github.com/pypa/gh-action-pypi-publish/commit/9b4dfb0c84502497080469ffeb5e75f9c5cce5c2"><code>9b4dfb0</code></a> ✨ Pre-install Python if there's none</li>
<li><a href="https://github.com/pypa/gh-action-pypi-publish/commit/0a87186d5f9e2303ed3c19e0fdd59abe52a28bb7"><code>0a87186</code></a> Merge pull request <a href="https://redirect.github.com/pypa/gh-action-pypi-publish/issues/293">https://github.com/facebookincubator/velox/issues/293</a> from webknjaz/bugfixes/uncheckout-intermediate-action</li>
<li><a href="https://github.com/pypa/gh-action-pypi-publish/commit/dfcfeca43e4ad1597a1a8bacfca40b25ad821f61"><code>dfcfeca</code></a> 🧪 Use prefetched action to make trampoline</li>
<li><a href="https://github.com/pypa/gh-action-pypi-publish/commit/0d02f372c36f840ef9312c8ce9d8f06d74a8a521"><code>0d02f37</code></a> 📝💅 Update the CI/CD badge in README</li>
<li><a href="https://github.com/pypa/gh-action-pypi-publish/commit/61da13deb5f5124fb1536194f82ed3d9bbc7e8f3"><code>61da13d</code></a> Merge pull request <a href="https://redirect.github.com/pypa/gh-action-pypi-publish/issues/230">https://github.com/facebookincubator/velox/issues/230</a> from br3ndonland/ghcr</li>
<li>Additional commits viewable in <a href="https://github.com/pypa/gh-action-pypi-publish/compare/v1.6.4...v1.12.2">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pypa/gh-action-pypi-publish&package-manager=github_actions&previous-version=1.6.4&new-version=1.12.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: #11494

Reviewed By: zacw7

Differential Revision: D66560251

Pulled By: xiaoxmeng

fbshipit-source-id: 1a6fe999a0ef7b99e81f9553db129f3f84b80769
  • Loading branch information
dependabot[bot] authored and facebook-github-bot committed Nov 29, 2024
1 parent af20b93 commit ac5c15e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build_pyvelox.yml
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ jobs:
python-version: "3.10"

- name: Publish a Python distribution to PyPI
uses: pypa/gh-action-pypi-publish@v1.6.4
uses: pypa/gh-action-pypi-publish@v1.12.2
with:
password: ${{ secrets.PYPI_API_TOKEN }}
packages_dir: wheelhouse

0 comments on commit ac5c15e

Please sign in to comment.