This repository has been archived by the owner on Nov 2, 2018. It is now read-only.
Provide a graphical Windows installer #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -62,7 +62,6 @@ version (Windows) { | |||
| Runtime.initialize(); | |||
| import core.memory; | |||
| GC.disable(); | |||
| assert(false, "Debugging an issue whereby this function is not called"); | |||
There was a problem hiding this comment.
this was failing the os x build as the next line is unreachable
|
Fixes #19 for Windows |
| @@ -0,0 +1,99 @@ | |||
| !define APPNAME "Presto ODBC Driver" | |||
There was a problem hiding this comment.
Should you add "64 bit" somewhere in the name as well?
|
LGTM, a few nits only - please let us know if any change and then let's pull this. |
|
@andralex Addressed your comments, thanks for looking into this. |
|
merged, thanks much |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a graphical Windows installer for the ODBC driver built using nsis (http://nsis.sourceforge.net). I haven't committed the installer executable with this PR, but you can check it out here: https://github.com/nezihyigitbasi/presto-odbc/tree/binaries/binaries/64-bit. I have successfully tested the installer with Windows 7 and Windows Server 2012.