Don't use trailrunner to format exactly one file #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Bobronium! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
The only thing to manually check here is that |
|
Fixed benchmark test, and added a second benchmark test that triggers multiprocessing. |
|
Thank you! |
amyreese
added a commit
to amyreese/usort
that referenced
this pull request
May 17, 2022
Previously, when passing multiple paths to the usort CLI, it would call `usort_path()` separately for each path given, preventing any chance of parallel processing. This means `usort check usort/**/*.py` would take ~10X longer than `usort check usort`: ``` (.venv) jreese@butterfree ~/workspace/usort main » time usort check usort usort check usort 3.64s user 0.32s system 338% cpu 1.169 total (.venv) jreese@butterfree ~/workspace/usort main » time usort check usort usort usort usort check usort usort usort 10.67s user 0.89s system 470% cpu 2.458 total (.venv) jreese@butterfree ~/workspace/usort main » time usort check usort/**/*.py usort/**/*.py usort/**/*.py usort check usort/**/*.py usort/**/*.py usort/**/*.py 13.41s user 1.59s system 62% cpu 24.141 total ``` With the changes from facebook#160, this is partially masked by removing the cost of starting child processes, but still results in linear time increase when passing many arguments: ``` (.venv) jreese@butterfree ~/workspace/usort patch-1 » time usort check usort usort check usort 3.68s user 0.36s system 318% cpu 1.267 total (.venv) jreese@butterfree ~/workspace/usort patch-1 » time usort check usort usort usort usort check usort usort usort 10.37s user 0.86s system 483% cpu 2.323 total (.venv) jreese@butterfree ~/workspace/usort patch-1 » time usort check usort/**/*.py usort/**/*.py usort/**/*.py usort check usort/**/*.py usort/**/*.py usort/**/*.py 2.45s user 0.06s system 89% cpu 2.803 total ``` This builds on facebook#160 by updating `usort_path()` to optionally take an iterable of Path objects, and materializes a set of paths to sort before actually starting child processes. This allows maximum utilization of multiprocessing, and also eliminates any double-formatting if the CLI arguments include any overlap of paths: ``` (.venv) jreese@butterfree ~/workspace/usort gather ‹1› » time usort check usort usort check usort 3.82s user 0.36s system 333% cpu 1.255 total (.venv) jreese@butterfree ~/workspace/usort gather » time usort check usort usort usort usort check usort usort usort 3.88s user 0.37s system 356% cpu 1.192 total (.venv) jreese@butterfree ~/workspace/usort gather » time usort check usort/**/*.py usort/**/*.py usort/**/*.py usort check usort/**/*.py usort/**/*.py usort/**/*.py 3.68s user 0.36s system 323% cpu 1.249 total ```
amyreese
added a commit
to amyreese/usort
that referenced
this pull request
May 17, 2022
Previously, when passing multiple paths to the usort CLI, it would call `usort_path()` separately for each path given, preventing any chance of parallel processing. This means `usort check usort/**/*.py` would take ~10X longer than `usort check usort`, and also results in double formatting if a path appeared or was a child of multiple arguments: ``` (.venv) jreese@butterfree ~/workspace/usort main » time usort check usort usort check usort 3.64s user 0.32s system 338% cpu 1.169 total (.venv) jreese@butterfree ~/workspace/usort main » time usort check usort usort usort usort check usort usort usort 10.67s user 0.89s system 470% cpu 2.458 total (.venv) jreese@butterfree ~/workspace/usort main » time usort check usort/**/*.py usort/**/*.py usort/**/*.py usort check usort/**/*.py usort/**/*.py usort/**/*.py 13.41s user 1.59s system 62% cpu 24.141 total ``` With the changes from facebook#160, this is partially masked by removing the cost of starting child processes, but still results in linear time increase when passing many arguments: ``` (.venv) jreese@butterfree ~/workspace/usort patch-1 » time usort check usort usort check usort 3.68s user 0.36s system 318% cpu 1.267 total (.venv) jreese@butterfree ~/workspace/usort patch-1 » time usort check usort usort usort usort check usort usort usort 10.37s user 0.86s system 483% cpu 2.323 total (.venv) jreese@butterfree ~/workspace/usort patch-1 » time usort check usort/**/*.py usort/**/*.py usort/**/*.py usort check usort/**/*.py usort/**/*.py usort/**/*.py 2.45s user 0.06s system 89% cpu 2.803 total ``` This builds on facebook#160 by updating `usort_path()` to optionally take an iterable of Path objects, and materializes a set of paths to sort before actually starting child processes. This allows maximum utilization of multiprocessing, and also eliminates any double-formatting if the CLI arguments include any overlap of paths: ``` (.venv) jreese@butterfree ~/workspace/usort gather ‹1› » time usort check usort usort check usort 3.82s user 0.36s system 333% cpu 1.255 total (.venv) jreese@butterfree ~/workspace/usort gather » time usort check usort usort usort usort check usort usort usort 3.88s user 0.37s system 356% cpu 1.192 total (.venv) jreese@butterfree ~/workspace/usort gather » time usort check usort/**/*.py usort/**/*.py usort/**/*.py usort check usort/**/*.py usort/**/*.py usort/**/*.py 3.68s user 0.36s system 323% cpu 1.249 total ```
amyreese
added a commit
to amyreese/usort
that referenced
this pull request
May 18, 2022
Previously, when passing multiple paths to the usort CLI, it would call `usort_path()` separately for each path given, preventing any chance of parallel processing. This means `usort check usort/**/*.py` would take ~10X longer than `usort check usort`, and also results in double formatting if a path appeared or was a child of multiple arguments: ``` (.venv) jreese@butterfree ~/workspace/usort main » time usort check usort usort check usort 3.64s user 0.32s system 338% cpu 1.169 total (.venv) jreese@butterfree ~/workspace/usort main » time usort check usort usort usort usort check usort usort usort 10.67s user 0.89s system 470% cpu 2.458 total (.venv) jreese@butterfree ~/workspace/usort main » time usort check usort/**/*.py usort/**/*.py usort/**/*.py usort check usort/**/*.py usort/**/*.py usort/**/*.py 13.41s user 1.59s system 62% cpu 24.141 total ``` With the changes from facebook#160, this is partially masked by removing the cost of starting child processes, but still results in linear time increase when passing many arguments: ``` (.venv) jreese@butterfree ~/workspace/usort patch-1 » time usort check usort usort check usort 3.68s user 0.36s system 318% cpu 1.267 total (.venv) jreese@butterfree ~/workspace/usort patch-1 » time usort check usort usort usort usort check usort usort usort 10.37s user 0.86s system 483% cpu 2.323 total (.venv) jreese@butterfree ~/workspace/usort patch-1 » time usort check usort/**/*.py usort/**/*.py usort/**/*.py usort check usort/**/*.py usort/**/*.py usort/**/*.py 2.45s user 0.06s system 89% cpu 2.803 total ``` This builds on facebook#160 by updating `usort_path()` to optionally take an iterable of Path objects, and materializes a set of paths to sort before actually starting child processes. This allows maximum utilization of multiprocessing, and also eliminates any double-formatting if the CLI arguments include any overlap of paths: ``` (.venv) jreese@butterfree ~/workspace/usort gather ‹1› » time usort check usort usort check usort 3.82s user 0.36s system 333% cpu 1.255 total (.venv) jreese@butterfree ~/workspace/usort gather » time usort check usort usort usort usort check usort usort usort 3.88s user 0.37s system 356% cpu 1.192 total (.venv) jreese@butterfree ~/workspace/usort gather » time usort check usort/**/*.py usort/**/*.py usort/**/*.py usort check usort/**/*.py usort/**/*.py usort/**/*.py 3.68s user 0.36s system 323% cpu 1.249 total ```
amyreese
added a commit
to amyreese/usort
that referenced
this pull request
Jul 22, 2022
Don't use trailrunner to format exactly one file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #159
This optimises for a common use case when only one file is provided.
This change might belong to
trailrunnerrepo as well.