[isl] reduce number of pr fetched in graphql query to avoid timeouts

[vuduchild]

When using 100 PRs, I often encounter errors resulting of Github timeouts. Reducing the number of PRs we're fetching solves the issue.
A possibly more elegant future solution would be to specify which PRs' data we're interested in fetching.

---

Stack created with Sapling.

• -> [isl] reduce number of pr fetched in graphql query to avoid timeouts #782
• [isl] increase width of diff window in split stack edit panel #781

[facebook-github-bot]

Hi @vuduchild!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[evangrayk]

Thanks for the PR!

20 is a little low, I would certainly start running into that limit in my work. But if we're currently unable to fetch because the limit is too high we probably should reduce it. Not sure what the right number is honestly. We probably need to be doing some batching somehow to support fetching however PRs many we need, but not all in one go to avoid errors.

Does your problem get fixed even with a higher number? say, 50?

[vuduchild]

@evangrayk - yes, 50 still works, just makes the request take slightly longer. I'll change it.

My suggestion for a future implementation would be to still batch the call, but to perhaps experiment with specifying which PRs we're interested in (if the API supports it). This should limit the size of the results and perhaps reduce the server processing time.

[facebook-github-bot]

@vuduchild has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@evangrayk merged this pull request in ec38704.