gitcompat: add call_git to capture output

Summary:
This handles some error cases like non-zero exit code with a nicer error
message than the stdlib default.

Reviewed By: muirdm

Differential Revision: D54218742

fbshipit-source-id: afc3747007ce378b9506ba06365088578517e131

eden/scm/lib/gitcompat/Cargo.toml

@@ -9,3 +9,4 @@ edition = "2021"
 configmodel = { version = "0.1.0", path = "../config/model" }
 fs-err = { version = "2.6.0", features = ["tokio"] }
 identity = { version = "0.1.0", path = "../identity" }
+spawn-ext = { version = "0.1.0", path = "../spawn-ext" }

eden/scm/lib/gitcompat/TARGETS

@@ -10,5 +10,6 @@ rust_library(
         "fbsource//third-party/rust:fs-err",
         "//eden/scm/lib/config/model:configmodel",
         "//eden/scm/lib/identity:identity",
+        "//eden/scm/lib/spawn-ext:spawn-ext",
     ],
 )

eden/scm/lib/gitcompat/src/rungit.rs

@@ -5,11 +5,15 @@
  * GNU General Public License version 2.
  */
 
+use std::io;
 use std::path::PathBuf;
 use std::process::Command;
+use std::process::ExitStatus;
+use std::process::Output;
 
 use configmodel::Config;
 use configmodel::ConfigExt;
+use spawn_ext::CommandExt;
 
 /// Options used by `run_git`.
 #[derive(Default, Clone)]
@@ -57,6 +61,18 @@ impl RunGitOptions {
         let args = args.iter().map(ToString::to_string).collect();
         git_cmd_impl(cmd_name, args, self)
     }
+
+    /// Call `git`. Check exit code. Capture output.
+    pub fn call(&self, cmd_name: &str, args: &[impl ToString]) -> io::Result<Output> {
+        let mut cmd = self.git_cmd(cmd_name, args);
+        cmd.checked_output()
+    }
+
+    /// Run `git`. Check exit code.
+    pub fn run(&self, cmd_name: &str, args: &[impl ToString]) -> io::Result<ExitStatus> {
+        let mut cmd = self.git_cmd(cmd_name, args);
+        cmd.checked_run()
+    }
 }
 
 const GIT: &str = "git";