Skip to content

Commit

Permalink
remove unused imports (1/3)
Browse files Browse the repository at this point in the history
Summary:
Codehub raises unused imports as one of the most common issues in our codebase: https://fburl.com/quality/7w3p7qic
There is a codemod automation that finds and fixes these issues: https://fb.workplace.com/groups/pythonfoundation/permalink/2799727247007403/
I've run it with
```
$ ./python/libcst/libcst codemod remove_unused_imports.RemoveUnusedImportsWithGlean eden/mononoke
```
using a different directory in each diff
Then `arc lint` to fix autodeps where removing the imports removes a dependency.

*Impact*
A lot of these files are not used frequently, this cleanup still improves code legibility, solves possible naming issues, and potentially speeds up builds (I will not be measuring these).

Reviewed By: lmvasquezg

Differential Revision: D66874508

fbshipit-source-id: 4fee086907fb5ce62d43d2b159f522d200b4a3c6
  • Loading branch information
Clara Rull authored and facebook-github-bot committed Dec 6, 2024
1 parent 79c30a5 commit d41062e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion eden/mononoke/tests/integration/integration_runner_real.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
import sys
import tempfile
import xml.etree.ElementTree as ET
from typing import Any, Dict, List, NamedTuple, Optional, Set
from typing import Any, Dict, List, NamedTuple, Optional

import click

Expand Down

0 comments on commit d41062e

Please sign in to comment.