commit cloud: forbid sharing for workspaces with non-ascii characters

Summary: Nonascii characters don't play well with ACL names, so let's do that validation before attempting to create an ACL in the first place

Reviewed By: muirdm

Differential Revision: D68024940

fbshipit-source-id: 25f544b4316a2e4f09f3f8f203958355bedb3540

eden/mononoke/commit_cloud/helpers/lib.rs

@@ -48,7 +48,7 @@ pub fn decorate_workspace_name_to_valid_acl_name(name: &str) -> String {
     workspace_decorated = workspace_decorated
         .chars()
         .map(|c| {
-            if c.is_alphanumeric() || allowed_punctuation.contains(&c) {
+            if c.is_ascii_alphanumeric() || allowed_punctuation.contains(&c) {
                 c
             } else {
                 '_'
@@ -133,5 +133,9 @@ mod test {
             ),
             "user/testuser_oculus.com/other_name_with_spaces"
         );
+        assert_eq!(
+            decorate_workspace_name_to_valid_acl_name("user/testuser/秘密项目"),
+            "user/testuser/____"
+        );
     }
 }