Fix more rustc lints

Reviewed By: dtolnay

Differential Revision: D50060980

fbshipit-source-id: 43797827c6e2b5a60e29c0bc3a530515f2c831c1

eden/mononoke/blobstore/factory/src/blobstore.rs

@@ -611,7 +611,13 @@ pub fn make_blobstore_unlink_ops<'a>(
                 }
                 #[cfg(not(fbcode_build))]
                 {
-                    let _ = (bucket, region, num_concurrent_operations);
+                    let _ = (
+                        aws_account_id,
+                        aws_role,
+                        bucket,
+                        region,
+                        num_concurrent_operations,
+                    );
                     unimplemented!("This is implemented only for fbcode_build")
                 }
             }

eden/mononoke/cmdlib/caching/src/lib.rs

@@ -11,6 +11,7 @@ pub mod facebook;
 mod settings;
 
 use environment::Caching;
+#[cfg(fbcode_build)]
 use environment::LocalCacheConfig;
 use fbinit::FacebookInit;
 

eden/mononoke/derived_data/mercurial_derivation/test/main.rs

@@ -6,20 +6,23 @@
  */
 
 #![cfg_attr(not(fbcode_build), allow(unused_crate_dependencies))]
+
 mod file_history_test;
 mod tracing_blobstore;
 mod utils;
 
 use std::collections::BTreeMap;
 use std::collections::HashMap;
 use std::sync::Arc;
+#[cfg(fbcode_build)]
 use std::time::Duration;
 
 use ::manifest::Entry;
 use ::manifest::Manifest;
 use ::manifest::ManifestOps;
 use anyhow::Error;
 use assert_matches::assert_matches;
+#[cfg(fbcode_build)]
 use async_trait::async_trait;
 use blobrepo::BlobRepo;
 use blobrepo_errors::ErrorKind;

eden/mononoke/permission_checker/src/oss.rs

@@ -90,7 +90,7 @@ impl MononokeIdentitySetExt for MononokeIdentitySet {
         self.iter().map(ToString::to_string).join(",")
     }
 
-    fn identity_type_filtered_concat(&self, id_type: &str) -> Option<String> {
+    fn identity_type_filtered_concat(&self, _id_type: &str) -> Option<String> {
         None
     }
 }

eden/mononoke/repo_factory/src/lib.rs

@@ -78,6 +78,7 @@ use deletion_log::DeletionLog;
 use deletion_log::SqlDeletionLog;
 #[cfg(fbcode_build)]
 use derived_data_client_library::Client as DerivationServiceClient;
+#[cfg(fbcode_build)]
 use derived_data_remote::Address;
 use derived_data_remote::DerivationClient;
 use derived_data_remote::RemoteDerivationOptions;

eden/mononoke/server/metadata/src/security/oss.rs

@@ -7,7 +7,7 @@
 
 use anyhow::Result;
 
-pub fn is_client_untrusted<GetHeaderFn>(headers: GetHeaderFn) -> Result<bool>
+pub fn is_client_untrusted<GetHeaderFn>(_headers: GetHeaderFn) -> Result<bool>
 where
     GetHeaderFn: Fn(&str) -> Result<Option<String>>,
 {

eden/mononoke/server/repo_listener/src/http_service.rs

@@ -16,6 +16,7 @@ use anyhow::Context;
 use anyhow::Error;
 use anyhow::Result;
 use bookmarks::BookmarksRef;
+#[cfg(fbcode_build)]
 use clientinfo::ClientEntryPoint;
 #[cfg(fbcode_build)]
 use clientinfo::ClientInfo;