Fix CI errors

Summary: Three Issues - A local storage key was not added to the type - Bad formatting on an html file - Type error from unexpected `undefined` Reviewed By: muirdm Differential Revision: D65545256 fbshipit-source-id: 24c3bd1e939bfe1d29c5322e954aba0f5bff02a8
facebook · Nov 7, 2024 · 9f823d8 · 9f823d8
1 parent 740bd93
commit 9f823d8
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 12 deletions.
diff --git a/addons/isl-server/src/ServerToClientAPI.ts b/addons/isl-server/src/ServerToClientAPI.ts
@@ -907,7 +907,7 @@ export default class ServerToClientAPI {
             context: diff,
             fieldName: data.fieldName,
             summary: data.summary,
-            testPlan: data.testPlan,
+            testPlan: data.testPlan ?? '',
             title: data.title,
           })
             .catch((error: Error) => ({error}))

diff --git a/addons/isl/src/types.ts b/addons/isl/src/types.ts
@@ -752,6 +752,7 @@ export type LocalStorageName =
   | 'isl.auto-resolve-before-continue'
   | 'isl.warn-about-diagnostics'
   | 'isl.hide-non-blocking-diagnostics'
+  | 'isl.rebase-off-warm-warning-enabled'
   // These keys are prefixes, with further dynamic keys appended afterwards
   | 'isl.edited-commit-messages:';
 

diff --git a/addons/vscode/inlineCommentSidePanelWebview.html b/addons/vscode/inlineCommentSidePanelWebview.html
@@ -1,15 +1,15 @@
 <!DOCTYPE html>
 <html lang="en">
+  <head>
+    <meta charset="utf-8" />
+    <meta name="viewport" content="width=device-width, initial-scale=1" />
+    <meta name="referrer" content="no-referrer" />
+  </head>
 
-<head>
-  <meta charset="utf-8" />
-  <meta name="viewport" content="width=device-width, initial-scale=1" />
-  <meta name="referrer" content="no-referrer" />
-</head>
-
-<body>
-  <div id="root"></div>
-  <script type="module" src="/extension/facebook/comments/webview/InlineCommentSidePanelWebview.tsx"></script>
-</body>
-
+  <body>
+    <div id="root"></div>
+    <script
+      type="module"
+      src="/extension/facebook/comments/webview/InlineCommentSidePanelWebview.tsx"></script>
+  </body>
 </html>