Skip to content

Commit

Permalink
save some CI diskspace, use ubuntu 20.04 and later libgit2 (#693)
Browse files Browse the repository at this point in the history
Summary:
X-link: facebookincubator/velox#6925

save some CI diskspace, use ubuntu 20.04 and later libgit2

Save some time and diskspace in CI builds for github by using the system libraries

Pull Request resolved: #693

Test Plan:
Install deps and build locally with

```
sudo ./build/fbcode_builder/getdeps.py --allow-system-packages install-system-deps --recursive eden
...
./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden

```

before: we build libgit2 from source
after: we use the system library

 ---
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/693).
* __->__ #693
* #696
* #692
* #691
* #682
* #689
* #697
* #706
* #730

Reviewed By: quark-zju, xavierd

Differential Revision: D49874384

Pulled By: genevievehelsel

fbshipit-source-id: 09c01eec69446c9bfa95861d9e71617b44b44fce
  • Loading branch information
ahornby authored and facebook-github-bot committed Oct 7, 2023
1 parent 0a17a93 commit 7cd4cec
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions build/fbcode_builder/manifests/libgit2
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ libgit2-devel
# Ubuntu 18.04 libgit2 has clash with libcurl4-openssl-dev as it depends on
# libcurl4-gnutls-dev. Should be ok from 20.04 again
# There is a description at https://github.com/r-hub/sysreqsdb/issues/77
# [debs]
# libgit2-dev
[debs.not(all(distro=ubuntu,distro_vers="18.04"))]
libgit2-dev

[download]
url = https://github.com/libgit2/libgit2/archive/v0.28.1.tar.gz
Expand Down

0 comments on commit 7cd4cec

Please sign in to comment.