Skip to content

Commit

Permalink
Fix failing Mononoke Git integration test
Browse files Browse the repository at this point in the history
Summary: When `test-mononoke-git-server-push-with-fb-product-log.t` was created, the underlying git client used in integration test would auto populate the header `x-fb-product-log`. However, at one point that stopped being true which led to this integration test consistently failing. While this problem gets fixed in production, this diff atleast fixes the integration test

Reviewed By: singhsrb

Differential Revision: D67518509

fbshipit-source-id: d82aa3cb3af582ee2d6371d0e1f402dd71628d05
  • Loading branch information
RajivTS authored and facebook-github-bot committed Dec 20, 2024
1 parent e3b1a31 commit 6f5bc0a
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
# Start up the Mononoke Git Service
$ mononoke_git_service
# Clone the Git repo from Mononoke
$ git_client clone $MONONOKE_GIT_SERVICE_BASE_URL/$REPONAME.git
$ git_client -c http.extraHeader="x-fb-product-log: git:123:pid1234_1234" clone $MONONOKE_GIT_SERVICE_BASE_URL/$REPONAME.git
Cloning into 'repo'...
$ cd repo

Expand All @@ -49,7 +49,7 @@
$ git commit -qam "Another commit on master_bookmark"

# Push all the changes made so far
$ git_client push origin master_bookmark
$ git_client -c http.extraHeader="x-fb-product-log: git:123:pid1234_5678" push origin master_bookmark
To https://localhost:$LOCAL_PORT/repos/git/ro/repo.git
e8615d6..60fb9c7 master_bookmark -> master_bookmark

Expand All @@ -58,4 +58,4 @@

# Verify the push validation errors got recorded in scuba
$ jq -S .normal "$SCUBA" | grep product | wc -l
25
21

0 comments on commit 6f5bc0a

Please sign in to comment.