Skip to content

Commit

Permalink
stackEditState: rename getRevs to joinRevs
Browse files Browse the repository at this point in the history
Summary: The new name better reflects what it does.

Reviewed By: muirdm

Differential Revision: D67060051

fbshipit-source-id: 75390cc104a41db7d7e498bbf271c57cfe0063f9
  • Loading branch information
quark-zju authored and facebook-github-bot committed Dec 12, 2024
1 parent 66dc1e7 commit 637b6a6
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions addons/isl/src/stackEdit/ui/stackEditState.ts
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ registerDisposable(
clientToServerAPI.onMessageOfType('exportedStack', event => {
writeAtom(stackEditState, (prev): StackEditState => {
const {hashes, intention} = prev;
const revs = getRevs(hashes);
const revs = joinRevs(hashes);
if (revs !== event.revs) {
// Wrong stack. Ignore it.
return prev;
Expand Down Expand Up @@ -309,7 +309,7 @@ export const editingStackIntentionHashes = atom<
await waiter;
}
if (hashes.size > 0) {
const revs = getRevs(hashes);
const revs = joinRevs(hashes);
clientToServerAPI.postMessage({type: 'exportStack', revs});
}
set(stackEditState, {
Expand Down Expand Up @@ -456,7 +456,7 @@ export function useStackEditState() {
}

/** Get revset expression for requested hashes. */
function getRevs(hashes: Set<Hash>): string {
function joinRevs(hashes: Set<Hash>): string {
return [...hashes].join('|');
}

Expand Down

0 comments on commit 637b6a6

Please sign in to comment.