Use RepoPermissionChecker facet in Mononoke Git Server

Summary: We will start enforcing ACL based checking in Mononoke Git Server, and the first step for that is to include the RepoPermissionChecker facet as part of the Repo facet container. This will be used in a diff later in the stack. Reviewed By: mitrandir77 Differential Revision: D55796149 fbshipit-source-id: 3903f1114a3c2bf2a7e50f0891076b6195e8476e
facebook · Apr 6, 2024 · 107fae5 · 107fae5
1 parent 0be4243
commit 107fae5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/eden/mononoke/git_server/Cargo.toml b/eden/mononoke/git_server/Cargo.toml
@@ -46,6 +46,7 @@ protocol = { version = "0.1.0", path = "../git/protocol" }
 repo_blobstore = { version = "0.1.0", path = "../blobrepo/repo_blobstore" }
 repo_derived_data = { version = "0.1.0", path = "../repo_attributes/repo_derived_data" }
 repo_identity = { version = "0.1.0", path = "../repo_attributes/repo_identity" }
+repo_permission_checker = { version = "0.1.0", path = "../repo_attributes/repo_permission_checker" }
 secure_utils = { version = "0.1.0", git = "https://github.com/facebookexperimental/rust-shed.git", branch = "main" }
 serde = { version = "1.0.185", features = ["derive", "rc"] }
 sharding_ext = { version = "0.1.0", path = "../cmdlib/sharding_ext" }

diff --git a/eden/mononoke/git_server/TARGETS b/eden/mononoke/git_server/TARGETS
@@ -52,6 +52,7 @@ rust_binary(
         "//eden/mononoke/repo_attributes/commit_graph/commit_graph:commit_graph",
         "//eden/mononoke/repo_attributes/repo_derived_data:repo_derived_data",
         "//eden/mononoke/repo_attributes/repo_identity:repo_identity",
+        "//eden/mononoke/repo_attributes/repo_permission_checker:repo_permission_checker",
         "//eden/mononoke/server/context:context",
         "//eden/scm/lib/clientinfo:clientinfo",
     ],

diff --git a/eden/mononoke/git_server/src/main.rs b/eden/mononoke/git_server/src/main.rs
@@ -60,6 +60,7 @@ use mononoke_app::MononokeReposManager;
 use repo_blobstore::RepoBlobstore;
 use repo_derived_data::RepoDerivedData;
 use repo_identity::RepoIdentity;
+use repo_permission_checker::RepoPermissionChecker;
 use slog::info;
 use tokio::net::TcpListener;
 
@@ -118,6 +119,9 @@ pub struct Repo {
 
     #[facet]
     commit_graph: CommitGraph,
+
+    #[facet]
+    repo_permission_checker: dyn RepoPermissionChecker,
 }
 
 /// Mononoke Git Server