-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Docusaurus with webpack 5 #3469
Conversation
ready for review |
@jstejada has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
@jstejada has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
nvm i was making a mistake, attempting to land this locally now |
@jsteiner @slorber I think this change causes an issue with zIndexes on the relay docs site: |
Hi
I'm sorry but I'm in holiday until 1st June
I believe this is some custom css on relay, as other docusaurus sites don't
have this problem
Le ven. 21 mai 2021 à 16:16, Christian Vuerings ***@***.***>
a écrit :
… @jsteiner <https://github.com/jsteiner> @slorber
<https://github.com/slorber> I think this change causes an issue with
zIndexes on the relay docs site:
[image: image]
<https://user-images.githubusercontent.com/127199/119151401-35317000-ba04-11eb-8d75-2ff3524867bb.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3469 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFW6PWORYI7DKHRQWFG7EDTOZTKNANCNFSM43ON326Q>
.
|
Fixing website CSS issue in #3505 |
Summary: Docusaurus beta 0 has been released so let's use it! Also, you are currently affected by an annoying regression in a Docusaurus transitive dependency ([email protected] => facebook/docusaurus#4826) Reported by christianvuerings here: #3469 (comment) ![image](https://user-images.githubusercontent.com/749374/120523199-ed342500-c3d5-11eb-9971-71d7106f1843.png) This should now be fixed by re-generating the lockfile. Pull Request resolved: #3505 Reviewed By: kassens Differential Revision: D28874560 Pulled By: rbalicki2 fbshipit-source-id: 6baece255be570abd5ec5f19f10e7f503be482f9
Use an unreleased version of Docusaurus to test the webpack5 support works for this site, detect potential problems, and perf improvements.
See also facebook/docusaurus#4089
Perf improvements
To get the benefits, it requires caching
node_modules/.cache
.It is not possible in GH actions, so I suggest migrating the site to Netlify and use the appropriate toml config (example: https://github.com/react-navigation/react-navigation.github.io/pull/974/files)
Unrelated suggestion: Relay has a lot of versions and long build/start times
Assuming nobody ever edit Relay docs of 2 years ago, you can improve the DX by limiting the number of versions display in dev with this docs plugin config:
For faster prod build, you can also move older docs to standalone deployments and link to them (see Jest for versions < 25 => https://jestjs.io/)