CMake: require CMAKE_BUILD_TYPE #1575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Instead of choosing defaults, require a build type to be explicitly specified. Differential Revision: D66795928
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66795928 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
Summary: Pull Request resolved: #1575 Instead of choosing defaults, require a build type to be explicitly specified. Reviewed By: avp Differential Revision: D66795928 fbshipit-source-id: 443d9a0971841deed73e63918c9294a61021c081
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Instead of choosing defaults, require a build type to be explicitly
specified.
Differential Revision: D66795928