-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[flow] Remove
react.ref_as_prop=disabled
override in component_synt…
…ax test suite Summary: The behavior remains mostly the same. The test is asserting that we are actually ignoring the ref prop in component spread. Before, we ignore it and subtype the ref prop in jsx against `React.ElementRef<typeof Component>`, which gives back `React.RefSetter<void>` and explains the previous error. Now with ref-as-prop, the ref prop appears as regular prop and subtype against the entire props object with spreaded ref prop intentionally dropped, so we get the prop-missing error. Changelog: [internal] Reviewed By: panagosg7 Differential Revision: D66849734 fbshipit-source-id: 870ed0bc794f76bf7daf15eef45862f9a5db053b
- Loading branch information
1 parent
5f4e844
commit f32b9ac
Showing
2 changed files
with
24 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters