Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if response is valid json #676

Closed
wants to merge 1 commit into from
Closed

fix: check if response is valid json #676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions facebook_business/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,6 @@ def body(self):
"""Returns the response body."""
return self._body

def json(self):
"""Returns the response body -- in json if possible."""
try:
return json.loads(self._body)
except (TypeError, ValueError):
return self._body

def headers(self):
"""Return the response headers."""
return self._headers
Expand All @@ -83,9 +76,12 @@ def status(self):
def is_success(self):
"""Returns boolean indicating if the call was successful."""

json_body = self.json()
try:
json_body = json.loads(self._body)
except (TypeError, ValueError):
return False

if isinstance(json_body, collections_abc.Mapping) and 'error' in json_body:
elif isinstance(json_body, collections_abc.Mapping) and 'error' in json_body:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only an elif?

# Is a dictionary, has error in it
return False
elif bool(json_body):
Expand Down