ref: add zwo as alternative for 2 #723
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@patapizza - hi Julien, is this repository not maintained anymore? |
chessai
reviewed
Oct 2, 2023
.github/workflows/ci.yml
Outdated
| @@ -12,7 +12,7 @@ jobs: | |||
| runs-on: ${{ matrix.os }} | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-latest, macOS-latest, windows-latest] | |||
Dockerfile
Outdated
| apt-get clean && \ | ||
| rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* | ||
|
|
||
| COPY --from=builder /root/.local/bin/duckling-example-exe /usr/local/bin/ | ||
|
|
||
| EXPOSE 8000 | ||
|
|
||
| CMD ["duckling-example-exe", "-p", "8000"] | ||
| CMD ["duckling-example-exe", "-p", "8000", "--no-access-log", "--no-error-log"] |
There was a problem hiding this comment.
these should be available by default
Duckling/Numeral/DE/NumParser.hs
Outdated
| import Data.String | ||
| import Prelude | ||
|
|
||
| newtype Parser a = Parser {runParser :: String -> Maybe (a, String)} |
There was a problem hiding this comment.
I'm pretty sure this parser type + NumParser stuff already exists elsewhere in the code case, you should import it
|
Hi @chessai , thank you for your time and attention on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have noticed that often in spoken german, people are using
zwoas an alternative tozwei. I tried to add in the german NumParser and corresponding rules. let me know if this is okay or i should make some changes to get it working.Thanks