Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix css url("image.png"), use css-loader v6 with esModules: false #6424

Merged
merged 3 commits into from
Jan 20, 2022
Merged

fix(core): fix css url("image.png"), use css-loader v6 with esModules: false #6424

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4aa473
revert css-loader to 5.x
slorber Jan 20, 2022
edf17f9
use css-loader v6
slorber Jan 20, 2022
9f20ec9
use css-loader v6
slorber Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/docusaurus/src/webpack/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,16 @@ import {memoize} from 'lodash';
// Utility method to get style loaders
export function getStyleLoaders(
isServer: boolean,
cssOptions: {
cssOptionsArg: {
[key: string]: unknown;
} = {},
): RuleSetRule[] {
const cssOptions: {[key: string]: unknown} = {
// TODO turn esModule on later, see https://github.com/facebook/docusaurus/pull/6424
esModule: false,
...cssOptionsArg,
};

if (isServer) {
return cssOptions.modules
? [
Expand Down