Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: declare missing dependencies #6097

Merged
merged 5 commits into from
Dec 13, 2021
Merged

fix: declare missing dependencies #6097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
31fd9f7
fix(utils-validation): add missing peer dependencies `react` and `rea…
merceyz Dec 11, 2021
8f4eb00
fix(theme-classic): add missing peer dependency `@docusaurus/core`
merceyz Dec 11, 2021
bd6e9cb
ci: disable PnP fallbacks
merceyz Dec 11, 2021
a55f2cd
ci: link to the docs
merceyz Dec 11, 2021
fb24179
Update package.json
Josh-Cena Dec 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/tests-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,10 @@ jobs:
yarn config set unsafeHttpWhitelist --json '["localhost"]'
yarn config set enableGlobalCache true

# Make PnP as strict as possible
# https://yarnpkg.com/features/pnp#fallback-mode
yarn config set pnpFallbackMode none

# Patch package so that peer deps are provided. This has been fixed in terser by making acorn a direct dependency
# TODO watch out for the next terser release. Commit: https://github.com/terser/terser/commit/05b23eeb682d732484ad51b19bf528258fd5dc2a
yarn config set packageExtensions --json '{"terser-webpack-plugin@*": {"dependencies": {"acorn": "^8.6.0"}}, "html-minifier-terser@*": {"dependencies": {"acorn": "^8.6.0"}}}'
Expand Down
2 changes: 1 addition & 1 deletion packages/docusaurus-theme-classic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"update-code-translations": "node -e 'require(\"./update-code-translations.js\").run()'"
},
"dependencies": {
"@docusaurus/core": "2.0.0-beta.13",
"@docusaurus/plugin-content-blog": "2.0.0-beta.13",
"@docusaurus/plugin-content-docs": "2.0.0-beta.13",
"@docusaurus/plugin-content-pages": "2.0.0-beta.13",
Expand All @@ -45,7 +46,6 @@
"rtlcss": "^3.3.0"
},
"devDependencies": {
"@docusaurus/core": "2.0.0-beta.13",
"@docusaurus/module-type-aliases": "2.0.0-beta.13",
"@docusaurus/types": "2.0.0-beta.13",
"@types/mdx-js__react": "^1.5.4",
Expand Down
4 changes: 4 additions & 0 deletions packages/docusaurus-utils-validation/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@
"joi": "^17.4.2",
"tslib": "^2.3.1"
},
"peerDependencies": {
"react": "*",
"react-dom": "*"
},
"engines": {
"node": ">=14"
}
Expand Down