Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): add documentation about importing code files #4974

Merged
merged 3 commits into from
Jun 15, 2021
Merged

docs(v2): add documentation about importing code files #4974

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e56020
Add documentation about importing code files
Josh-Cena Jun 15, 2021
b47655b
Add warning about breaking API change
Josh-Cena Jun 15, 2021
4068695
Update website/docs/guides/markdown-features/markdown-features-react.mdx
slorber Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions website/docs/guides/markdown-features/markdown-features-react.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,12 @@ You have to use `<CodeBlock>` rather than the Markdown triple-backtick ` ``` `,

:::
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a warning here and mention that this is experimental and API breaking changes are expected on this

we'll replace raw loader by https://webpack.js.org/guides/asset-modules/#replacing-inline-loader-syntax

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will work on this in a moment

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll replace raw loader by https://webpack.js.org/guides/asset-modules/#replacing-inline-loader-syntax

Should I change my demo case in the documentation, or is this just a plan?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't support ?raw syntax yet so we'll document it once we support it, for now you can keep documenting raw-loader usage

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I add a warning then, or should we just keep it in mind and come back once the support is in place?


:::warning

The `className="language-jsx"` prop is experimental and might be subject to breaking API changes in the future.
slorber marked this conversation as resolved.
Show resolved Hide resolved

:::

## Importing Markdown {#importing-markdown}

You can use Markdown files as components and import them elsewhere, either in Markdown files or in React pages. Below we are importing from [another file](./markdown-features-intro.mdx) and inserting it as a component.
Expand Down