Check for hasher role in /lookup endpoint #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dcallies
requested changes
Dec 23, 2024
| @@ -221,6 +223,26 @@ def test_banks_add_hash_index(app: Flask, client: FlaskClient): | |||
| assert post_response.json == {"matches": [2]} | |||
|
|
|||
|
|
|||
| def test_lookup_add_hash_without_role(app: Flask, client: FlaskClient): | |||
There was a problem hiding this comment.
nit: I don't think we're "adding" a hash in this unittest. In other tests, this is referring to banking functionality.
|
|
||
| # test GET | ||
| image_url = "https://github.com/facebook/ThreatExchange/blob/main/pdq/data/bridge-mods/aaa-orig.jpg?raw=true" | ||
| get_resp = client.get(f"/m/lookup?url={image_url}") |
There was a problem hiding this comment.
blocking: I don't see any existing unittests in this file that check against this endpoint at all (the others are using "raw_lookup". Can you also test a lookup is accepted?
This file is getting big enough that it may make sense to break out unittests for the different APIs.
|
@Dcallies should be GTG, thanks for the review! |
Dcallies
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #1703
TODO:
Test Plan
ROLE_HASHER = Falsein development_omm_config.py/lookupendpoint, should error now with 403 "Hashing is disabled, missing role"