[vpdq] Use scikit-build-core build backend for Python binding #1721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WIP. Follow up PR to some comments in #1711. Posting draft now in case I don't end up finishing it soon and someone else wants to pick it up and for general input. Seems like a no-brainer if it works, though.
Replace the hackish custom setup.py script that is used to build the Cython binding with scikit-build-core
Basic code skeleton taken from the scikit-build-core example
No API changes for the end user. ABI change is not a concern for the Python binding, as the entire library will be replaced on upgrade.
TODO:
Set [tool.scikit-build.cmake.build-type] to
RelWithDebInfo
Ensure we don't need
cmake
inrequires
inpyproject.toml
. Double check the scikit-build-core docs for this.Add scikit-build-core with a known good version to
requirements.txt
, remove setuptoolsTest Plan
CI tests building and installing locally.
TODO: