Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HMA] Remove IContentTypeConfigStore from HMA #1707

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

haianhng31
Copy link
Contributor

@haianhng31 haianhng31 commented Dec 11, 2024

Summary

@haianhng31 haianhng31 marked this pull request as draft December 11, 2024 21:20
@haianhng31 haianhng31 changed the title Remove IContentTypeConfigStore from HMA [HMA] Remove IContentTypeConfigStore from HMA Dec 11, 2024
Copy link
Contributor

@Dcallies Dcallies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the CI output, it looks like it's importing threatexchange 1.1.1

This is because our 1.2 version publish failed!

https://github.com/facebook/ThreatExchange/actions/runs/12247017442/job/34164057430

We'll have to fix that before this works

@@ -22,6 +22,7 @@

import flask

from threatexchange.cli.storage.interfaces import IContentTypeConfigStore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are getting a mypy failure here because this might need a missing __init.py__ file in the interfaces directory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know why mypy keeps complaining about not finding the module. I have checked:

  • threatexchange package is installed
  • threatexchange.storage.interfaces is a valid module
  • has __init__.py in interfaces directory

@Dcallies
Copy link
Contributor

Okay, I think I fixed the build and package, try re-submitting to see if everything passes again.

@Dcallies
Copy link
Contributor

Dcallies commented Dec 13, 2024

You have the same problem I fixed in #1718 - the __init__.py doesn't count unless it's non-empty - you'll need to add the copyright header to the __init__.py and then bump the version to release a new version of python-threatexchange. The CI is reading the released package version, not the code in repo (this is intentional, since that's how the production version of HMA works!)

You can confirm that the folder is included by running setup build and then inspecting the content of the build/ directory.

@@ -0,0 +1 @@
# Copyright (c) Meta Platforms, Inc. and affiliates.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to move this to its own PR, then we'll need to bump the version and release a new bugfix version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants