-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HMA] Remove IContentTypeConfigStore from HMA #1707
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the CI output, it looks like it's importing threatexchange 1.1.1
This is because our 1.2 version publish failed!
https://github.com/facebook/ThreatExchange/actions/runs/12247017442/job/34164057430
We'll have to fix that before this works
@@ -22,6 +22,7 @@ | |||
|
|||
import flask | |||
|
|||
from threatexchange.cli.storage.interfaces import IContentTypeConfigStore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are getting a mypy failure here because this might need a missing __init.py__
file in the interfaces directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't know why mypy keeps complaining about not finding the module. I have checked:
- threatexchange package is installed
threatexchange.storage.interfaces
is a valid module- has
__init__.py
in interfaces directory
Okay, I think I fixed the build and package, try re-submitting to see if everything passes again. |
You have the same problem I fixed in #1718 - the You can confirm that the folder is included by running |
@@ -0,0 +1 @@ | |||
# Copyright (c) Meta Platforms, Inc. and affiliates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to move this to its own PR, then we'll need to bump the version and release a new bugfix version!
Summary