Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an implementation of ConditionalWeakTable for JS/TS using WeakMap.
Missing/different behavior to .NET:
ConditionalWeakTable
is constructed, but I did not implement that.WeakMap
is not enumerable, it may be possible to support this by keeping an array ofWeakRef
s in addition to theWeakMap
. But this seems like a lot of overhead, especially since the .NET version only implementsIEnumerable
as an explicit implementation.new String(str)
With this PR, any
WeakMap
obtained from JS should be usable in F# as aConditionalWeakTable
, but theClear
method will only work onConditionalWeakTable
s constructed from F#.