Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HW3 is completed #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

HW3 is completed #3

wants to merge 4 commits into from

Conversation

ezhk
Copy link
Owner

@ezhk ezhk commented Jun 12, 2020

Домашнее задание №3 «Частотный анализ»

Критерии оценки

  • Пайплайн зелёный - 4 балла
  • Добавлены новые юнит-тесты - до 4 баллов
  • Понятность и чистота кода - до 2 баллов

Зачёт от 7 баллов

Comment on lines 9 to 10
var SplitFilter = regexp.MustCompile(`[\s?!.;,]`)
var IgnoredSymbols = regexp.MustCompile(`[-]`)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Переменные можно сделать неэкспортируемыми, поскольку они не используются вне пакета.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Поправил в последнем коммите :)
Экспортирование как-то влияет на расход памяти?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Скорее для инкапсуляции. Чтобы не было желания и возможности редактировать снаружи пакета.

agneum
agneum previously approved these changes Jun 13, 2020
Copy link
Collaborator

@agneum agneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо за выполненное задание. Отличная работа.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants