Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix content_scripts declaration adding extraneous css #215

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

cezaraugusto
Copy link
Member

Fix #213

@cezaraugusto cezaraugusto self-assigned this Oct 21, 2024
Copy link

pkg-pr-new bot commented Oct 21, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/extension-js/extension.js/extension@215
pnpm add https://pkg.pr.new/extension-js/extension.js/extension-create@215
pnpm add https://pkg.pr.new/extension-js/extension.js/extension-develop@215

commit: b2d3d4d

@wottpal
Copy link
Collaborator

wottpal commented Oct 25, 2024

Hey @cezaraugusto, somehow I get a different error when trying to build with this version (which prevents me to test it):

~/Developer/wottpal/google-maps-link-extension (main*) » bunx extension --version                                                                                                                                       zoma@dennis-mbp-4
2.0.0-beta.2
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
~/Developer/wottpal/google-maps-link-extension (main*) » EXTENSION_PUBLIC_PRODUCTION_MODE=true bunx extension build -b chrome                                                                                           zoma@dennis-mbp-4
node:fs:1506
  const result = binding.readdir(
                         ^

Error: ENOENT: no such file or directory, scandir '/Users/zoma/Developer/wottpal/google-maps-link-extension/dist/chrome/content_scripts'
    at Object.readdirSync (node:fs:1506:26)
    at /Users/zoma/Developer/wottpal/google-maps-link-extension/node_modules/extension-develop/dist/module.js:112:32169
    at Array.map (<anonymous>)
    at Ct.applyProdOverrides (/Users/zoma/Developer/wottpal/google-maps-link-extension/node_modules/extension-develop/dist/module.js:112:32043)
    at /Users/zoma/Developer/wottpal/google-maps-link-extension/node_modules/extension-develop/dist/module.js:112:33129
    at Hook.eval [as call] (eval at create (/Users/zoma/Developer/wottpal/google-maps-link-extension/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:7:1)
    at Hook.CALL_DELEGATE [as _call] (/Users/zoma/Developer/wottpal/google-maps-link-extension/node_modules/tapable/lib/Hook.js:14:14)
    at /Users/zoma/Developer/wottpal/google-maps-link-extension/node_modules/webpack/lib/Compilation.js:3184:40
    at eval (eval at create (/Users/zoma/Developer/wottpal/google-maps-link-extension/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:15:1)
    at fn (/Users/zoma/Developer/wottpal/google-maps-link-extension/node_modules/webpack/lib/Compilation.js:500:9) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'scandir',
  path: '/Users/zoma/Developer/wottpal/google-maps-link-extension/dist/chrome/content_scripts'
}

Node.js v20.18.0

@cezaraugusto
Copy link
Member Author

hey @wottpal thanks for catching up on this. I've send an update just now

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@cezaraugusto cezaraugusto force-pushed the extraneous-content-scripts branch 5 times, most recently from 1a57e73 to 61caae1 Compare October 25, 2024 22:49
@cezaraugusto cezaraugusto marked this pull request as ready for review October 26, 2024 13:13
@cezaraugusto
Copy link
Member Author

@wottpal ready for review!

Copy link
Collaborator

@wottpal wottpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm it's working now and accepted by the store w/o further modification 🫡

@cezaraugusto cezaraugusto merged commit f7e8843 into main Oct 28, 2024
15 checks passed
@cezaraugusto cezaraugusto deleted the extraneous-content-scripts branch October 28, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manifest content_scripts declaration adds extraneous css during build
2 participants