feat: System checks on SystemRequirements (cargo, rustc, msrv)
#379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o and rustc versions for CRAN compliance.
…_note.Rd`, and update NAMESPACE.
albersonmiranda
force-pushed
the
main
branch
from
07dbf5d to
6b6be3d
Compare
|
Just wanted to say, this looks impressive already. Keep up the good work @albersonmiranda! |
|
@Ilia-Kosenkov After extendr/extendr#844 it is now passing R CMD Check locally and it's ready to review. |
|
I got it that the version in |
JosiahParry
reviewed
Sep 7, 2024
JosiahParry
approved these changes
Sep 7, 2024
JosiahParry
changed the title
systemRequirementsSystemRequirements (cargo, rustc, msrv)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR updates
use_cran_defaults()to checkSystemRequirementsfield inDESCRIPTIONand perform a system check for bothRustandCargotools. If any of them is not found, build fails with a message to install them. If they are found, it checks for the minimum version ofrustc. If it is lower than specified inSystemRequirements, build fails with a message stating both installed and minimum version required. Finally, if all tests pass, it prints the version ofcargoandrustcfound, which will be used to build the package.Related Tickets & Documents
systemRequirements#378Added/updated tests?
Goal is code coverage percentage at 80% and above.
have not been included
Release checklist