-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nonAPI.txt #252
base: master
Are you sure you want to change the base?
Update nonAPI.txt #252
Conversation
@JosiahParry the non api has already changed. I think it is time to contact CRAN. |
These are affected: https://github.com/extendr/extendr/blob/d39d1d09ea024a31c3331a754baeafe3c7ae5b0e/extendr-api/src/robj/rinternals.rs#L358 Btw, I thought what CRAN requested to remove were only |
I don't know what is going on with CRAN and what they are doing to packages. In any case, I've made a PR that manually removes these from the cached bindings. Hopefully, not more chaos will ensue before we get |
The "non-API" Note doesn't always mean the death sentence from CRAN. For example, there's no label of "issues need fixing before ..." on vctrs even though the CRAN check displays the Note. https://cran.r-project.org/web/packages/vctrs/index.html So, I thought the difference is this part.
For example, duckdb gets "issues need fixing before ..." while it has only one non-API Note. https://cran.r-project.org/web/checks/check_results_duckdb.html |
Thanks! Let me know what you think I should do next. |
I think you can go ahead with #253 but it's not very urgent if it's not the hard requirement from CRAN. |
Please review the diff and run /bindings command manually.