feature: non-api adds non-API items to bindings
#237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allo non-api items to be part of the generated bindings. These bindings are not cached.
|
I've rebased, which broke this feature. Then I fixed it, and I've added the This is now ready for review. Let me know what you think. |
Ilia-Kosenkov
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to generate bindings that includes non-API items.
There are several reasons for this
Developer debugging As R-core is marking more items as non-API,
it might be desirable to have a feature to allow for experimenting.
It is only CRAN, and only a "NOTE": You might have good reasons for including aforementioned non-API items, therefore, these may be argued for.
libR-sysshould not solely be aiming to target CRAN, extendr (extendr-api) crates.. and more or less aim to serve as a sys-crate to R API in general.Note that these bindings are not cached, which means, to include non-API items, your system
must be setup to generate these bindings somehow.
Therefore, to generate these bindings you must enable this feature in the
Cargo.toml, e.g.