Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bindgen to 0.69.1 #192

Merged
merged 4 commits into from
Nov 5, 2023
Merged

Update bindgen to 0.69.1 #192

merged 4 commits into from
Nov 5, 2023

Conversation

CGMossa
Copy link
Member

@CGMossa CGMossa commented Nov 2, 2023

This should have absolutely no influence on bindings.

I saw a reaction at work, but that's because llvm 17 apparently snaps more comments in the bindings.
Now that I'm at home, this difference is not present.

But then now we can upgrade this in peace.

Also added -Wno-ignored-attributes because when you run this with

cargo clippy --features use-bindgen -vv

you see a warning

[libR-sys 0.6.0] clang diag: C:/rtools43/x86_64-w64-mingw32.static.posix/include\stdio.h:169:18: warning: '__format__' attribute argument not supported: gnu_scanf [-Wignored-attributes]

which we don't really care about, as we are creating bindings and not compiling this.

```
[libR-sys 0.6.0] clang diag: C:/rtools43/x86_64-w64-mingw32.static.posix/include\stdio.h:169:18: warning: '__format__' attribute argument not supported: gnu_scanf [-Wignored-attributes]
```
@CGMossa
Copy link
Member Author

CGMossa commented Nov 2, 2023

/bindings

@CGMossa CGMossa mentioned this pull request Nov 2, 2023
@CGMossa
Copy link
Member Author

CGMossa commented Nov 4, 2023

/bindings

@CGMossa CGMossa changed the title Update bindgen to 0.69.1 [DON'T MERGE THIS] Update bindgen to 0.69.1 Nov 4, 2023
@CGMossa
Copy link
Member Author

CGMossa commented Nov 4, 2023

The call to /bindings doesn't work on this. I think GitHub CI fails here.

@yutannihilation
Copy link
Contributor

I think GitHub CI fails here.

In case you don't notice, you can check the CI run here.

https://github.com/extendr/libR-sys/actions

@CGMossa
Copy link
Member Author

CGMossa commented Nov 5, 2023

/bindings

@CGMossa CGMossa changed the title [DON'T MERGE THIS] Update bindgen to 0.69.1 Update bindgen to 0.69.1 Nov 5, 2023
@CGMossa
Copy link
Member Author

CGMossa commented Nov 5, 2023

Dear @yutannihilation, I'd love it if you could take a final look at this, and merge when/if you find it done.

This was supposed to be a minor PR, but I knew there is always something coming up, and it is good these got addressed by you in #195.

These bindings also include the new OBJSXP value mentioned in extendr/extendr#664.

Copy link
Contributor

@yutannihilation yutannihilation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@yutannihilation yutannihilation merged commit b732695 into master Nov 5, 2023
@yutannihilation yutannihilation deleted the update_bindgen branch November 5, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants