-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bindgen
to 0.69.1
#192
Conversation
/bindings |
/bindings |
0.69.1
bindgen
to 0.69.1
The call to |
In case you don't notice, you can check the CI run here. |
/bindings |
bindgen
to 0.69.1
bindgen
to 0.69.1
Dear @yutannihilation, I'd love it if you could take a final look at this, and merge when/if you find it done. This was supposed to be a minor PR, but I knew there is always something coming up, and it is good these got addressed by you in #195. These bindings also include the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
This should have absolutely no influence on bindings.
I saw a reaction at work, but that's because
llvm 17
apparently snaps more comments in the bindings.Now that I'm at home, this difference is not present.
But then now we can upgrade this in peace.
Also added
-Wno-ignored-attributes
because when you run this withyou see a warning
which we don't really care about, as we are creating bindings and not compiling this.