-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add git status check before transformation #15
base: main
Are you sure you want to change the base?
Conversation
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
1a55f42
to
45369db
Compare
@@ -19,6 +19,7 @@ | |||
"dependencies": { | |||
"commander": "^12.1.0", | |||
"fast-glob": "^3.3.2", | |||
"is-git-clean": "^1.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we try to use child_process exec from nodejs instead of external lib?
https://nodejs.org/api/child_process.html#child_processexeccommand-options-callback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can, but if this package already does its job well, why not use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be that hard to achieve what you want with this proposal. It's probably a different story when something is complex or defeats the purpose of the library (for example commander).
If I had to choose between 10 different scripts vs 10 different packages for small or rather simple things I would pick the first option. It's better as you control this stuff and what it does.
If the given proposal with child_rocess can't be done easily we can revisit this topic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small changes required
45369db
to
2ed1b42
Compare
As the title says, and other folders are added that wouldn't appear in a real project and would only create noise