Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add git status check before transformation #15

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bjohansebas
Copy link
Member

As the title says, and other folders are added that wouldn't appear in a real project and would only create noise

@bjohansebas bjohansebas requested a review from kjugi January 9, 2025 22:17
@bjohansebas bjohansebas marked this pull request as draft January 9, 2025 22:18
Copy link

socket-security bot commented Jan 9, 2025

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] shell Transitive: environment, filesystem +22 180 kB jamestalmage

View full report↗︎

@bjohansebas bjohansebas marked this pull request as ready for review January 9, 2025 22:26
utils/git.ts Outdated Show resolved Hide resolved
@@ -19,6 +19,7 @@
"dependencies": {
"commander": "^12.1.0",
"fast-glob": "^3.3.2",
"is-git-clean": "^1.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try to use child_process exec from nodejs instead of external lib?
https://nodejs.org/api/child_process.html#child_processexeccommand-options-callback

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can, but if this package already does its job well, why not use it?

Copy link
Member

@kjugi kjugi Jan 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be that hard to achieve what you want with this proposal. It's probably a different story when something is complex or defeats the purpose of the library (for example commander).

If I had to choose between 10 different scripts vs 10 different packages for small or rather simple things I would pick the first option. It's better as you control this stuff and what it does.

If the given proposal with child_rocess can't be done easily we can revisit this topic

Copy link
Member

@kjugi kjugi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes required

@bjohansebas bjohansebas marked this pull request as draft January 13, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants