[build-tools] bump @expo/config and @expo/config-plugins version #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
requested review from
szdziedzic and
sjchmiela
as code owners
szdziedzic
reviewed
Nov 14, 2024
There was a problem hiding this comment.
I believe that to make it work in all cases after this upgrade, we would optimally need to do sth as I did for EAS CLI recently: expo/eas-cli#2529 (use npx expo config call to resolve config first if available to be able to resolve versioned config). I can try to do the same change here and bump the dependencies. Will let you know when it is ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Need to bump
@expo/configfor the SDK 52 release in order to read the app confignewArchEnabledvalue in turtle-v2How
bump
@expo/configand@expo/config-pluginsversionTest Plan
CI should be green