Add :bindings support
#21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is largely a port of @bnert's PR for sieppari ref: metosin/sieppari#55 The caveats from that PR regarding a small hit to performance, probably apply, though I did not do any benchmarking since the repo isn't setup for it.
|
Hi, It’s an interesting feature, but I don’t think we want to add this. One of the motivations for this library is to remain extremely simple (conceptually and in implementation) and that goes a bit against this. Then in term of functionality ‘ctx’ should be the logical place to propagate values through the chain instead of bindings, but you likely know about that already. |
|
Thanks for the feedback @mpenet, totally understand your position :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is largely a port of work from @robert-stuttaford and @bnert's PR for sieppari
ref: metosin/sieppari#55
The caveats from that PR regarding a small hit to performance, probably apply, though I did not do any benchmarking since the repo isn't setup for it.
Would close #20