Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configure ecms navigation and pages for administration site - EXO-66546 - Meeds-io/MIPs#88 #2189

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

IlhemEssaadi
Copy link
Contributor

No description provided.

@IlhemEssaadi IlhemEssaadi changed the title Add Cloud storage and Documents editors nodes to platform settings navigation - EXO-66546 - Meeds-io/MIPs#88 Add ecms nodes to platform settings navigation - EXO-66546 - Meeds-io/MIPs#88 Oct 11, 2023
@exo-swf exo-swf force-pushed the feature/experience branch from 95d0bc3 to c03813d Compare October 11, 2023 22:33
@azayati azayati changed the title Add ecms nodes to platform settings navigation - EXO-66546 - Meeds-io/MIPs#88 feat: Configure ecms navigation and pages for administration site - EXO-66546 - Meeds-io/MIPs#88 Oct 12, 2023
@@ -123,7 +123,39 @@
</object>
</object-param>
</init-params>
</component-plugin><component-plugin>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</component-plugin><component-plugin>
</component-plugin>
<component-plugin>

<label>#{portal.administration.transfert-rules}</label>
<icon>fas fa-exchange-alt</icon>
<page-reference>portal::administration::transferRules</page-reference>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

<title>Transfer Rules</title>
<access-permissions>*:/platform/administrators</access-permissions>
<edit-permission>manager:/platform/administrators</edit-permission>
<container id="singlePageApplicationContainer" template="system:/groovy/portal/webui/container/UIContainer.gtmpl">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<container id="singlePageApplicationContainer" template="system:/groovy/portal/webui/container/UIContainer.gtmpl">
<container id="singlePageApplicationContainer" template="system:/groovy/portal/webui/container/UIContainer.gtmpl" cssClass="singlePageApplication">

<title>Site Explorer</title>
<access-permissions>*:/platform/web-contributors</access-permissions>
<edit-permission>manager:/platform/web-contributors</edit-permission>
<container id="singlePageApplicationContainer" template="system:/groovy/portal/webui/container/UIContainer.gtmpl">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<container id="singlePageApplicationContainer" template="system:/groovy/portal/webui/container/UIContainer.gtmpl">
<container id="singlePageApplicationContainer" template="system:/groovy/portal/webui/container/UIContainer.gtmpl" cssClass="singlePageApplication">

@IlhemEssaadi IlhemEssaadi requested a review from azayati October 12, 2023 15:47
@@ -25,7 +25,7 @@
xsi:schemaLocation="http://www.exoplatform.org/xml/ns/kernel_1_2.xsd http://www.exoplatform.org/xml/ns/kernel_1_2.xsd"
xmlns="http://www.exoplatform.org/xml/ns/kernel_1_2.xsd">

<external-component-plugins>
<external-component-plugins>
<target-component>org.exoplatform.portal.config.UserPortalConfigService</target-component>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format that

@exo-swf exo-swf marked this pull request as draft October 12, 2023 15:57
@exo-swf
Copy link
Contributor

exo-swf commented Oct 12, 2023

Your PR triggers too many exo-ci builds! Please finish your work and then, set your PR ready! Thank you

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@IlhemEssaadi IlhemEssaadi marked this pull request as ready for review October 12, 2023 16:11
@IlhemEssaadi IlhemEssaadi requested a review from azayati October 12, 2023 16:27
Copy link
Member

@azayati azayati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azayati azayati merged commit 436f610 into feature/experience Oct 12, 2023
3 checks passed
@azayati azayati deleted the task/66546 branch October 12, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants