Skip to content

Commit

Permalink
Merge pull request #5 from exasol/refactoring/2_remotelog_as_module
Browse files Browse the repository at this point in the history
Refactoring/2 remotelog as module
  • Loading branch information
redcatbear authored Sep 3, 2020
2 parents 0ddf719 + f017297 commit 3cb66fc
Show file tree
Hide file tree
Showing 11 changed files with 36 additions and 323 deletions.
7 changes: 5 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,15 @@ Running the RLS Lua Virtual Schema requires a Exasol with built-in Lua 5.1 or la
| Dependency | Purpose | License |
|------------------------------------------|--------------------------------------------------------|-------------------------------|
| [Lua CJSON][luacjson] | JSON parsing and writing | MIT License |
| [LuaSocket][luasocket] | Socket communication | MIT License |
| [remotelog][remotelog] | Logging through a TCP socket | MIT License |

Note that Lua CSON and LuaSucket both are pre-installed on an Exasol database. For local unit testing you need to install them on the test machine though.
`remotelog` has a transitive dependency to [LuaSocket][luasocket] (MIT License). Note that Lua CSON and LuaSucket are pre-installed on an Exasol database.

For local unit testing you need to install them on the test machine though.

[luacjson]: https://www.kyne.com.au/~mark/software/lua-cjson.php
[luasocket]: http://w3.impa.br/~diego/software/luasocket/
[remotelog]: https://github.com/exasol/remotelog-lua

### Test Dependencies

Expand Down
3 changes: 3 additions & 0 deletions doc/changes/changelog.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Changes

* [0.1.0](changes_0.1.0.md)
22 changes: 22 additions & 0 deletions doc/changes/changes_0.1.0.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
row-level-security-lua, released 2020-09-03

Code name: Prototype

## Summary

The prototype offers tenant-security, and has full unit test and integration test coverage.

## Features / Enhancements

* #1: Prototype


## Refactoring

* #2: Removed `remotelog` sources and added the module as a LuaRocks dependency.

## Dependency updates

* Added `remotelog:1.0.0`

Note that `row-level-security-lua` also has dependencies to `cjson` and `luasockets`, both of which are pre-installed on Exasol.
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@
<argument>exasolrls.adapter</argument>
<argument>exasolrls.metadata_reader</argument>
<argument>exasolrls.query_rewriter</argument>
<argument>exasollog.log</argument>
<argument>remotelog</argument>
</arguments>
</configuration>
</execution>
Expand Down
221 changes: 0 additions & 221 deletions src/main/lua/exasollog/log.lua

This file was deleted.

2 changes: 1 addition & 1 deletion src/main/lua/exasolrls/metadata_reader.lua
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
local log = require("exasollog.log")
local log = require("remotelog")
local cjson require("cjson")

M = {}
Expand Down
2 changes: 1 addition & 1 deletion src/main/lua/exasolrls/query_rewriter.lua
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
local renderer = require("exasolvs.query_renderer")
local protection = require("exasolrls.table_protection_status")
local log = require("exasollog.log")
local log = require("remotelog")

local M = {}

Expand Down
2 changes: 1 addition & 1 deletion src/main/lua/exasolrls/table_protection_status.lua
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
local log = require("exasollog.log")
local log = require("remotelog")

local M = {}

Expand Down
2 changes: 1 addition & 1 deletion src/main/lua/exasolvs/request_dispatcher.lua
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
local log = require("exasollog.log")
local log = require("remotelog")
local cjson = require("cjson")
local adapter = require("exasolrls.adapter", "adapter")

Expand Down
94 changes: 0 additions & 94 deletions src/test/lua/exasollog/test_log.lua

This file was deleted.

Loading

0 comments on commit 3cb66fc

Please sign in to comment.