-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix create statement #710
Merged
pdambrauskas
merged 11 commits into
exacaster:master
from
jmilkiewicz:fix-create-statement
Oct 19, 2023
Merged
Fix create statement #710
pdambrauskas
merged 11 commits into
exacaster:master
from
jmilkiewicz:fix-create-statement
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmilkiewicz
commented
Oct 19, 2023
server/src/main/java/com/exacaster/lighter/application/sessions/SessionService.java
Show resolved
Hide resolved
jmilkiewicz
commented
Oct 19, 2023
jmilkiewicz
commented
Oct 19, 2023
...c/main/java/com/exacaster/lighter/rest/MicronautStatementCreationResultToResponseMapper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/exacaster/lighter/rest/SessionController.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/exacaster/lighter/rest/MicronautStatementCreationResultToResponseMapper.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/exacaster/lighter/rest/MicronautStatementCreationResultToResponseMapper.java
Outdated
Show resolved
Hide resolved
pdambrauskas
approved these changes
Oct 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #709
Note on implementation:
As of now
createStatement
can return one of 3 possible options:To model a function/method which can return one of these 3 options (with each of them having complete different shape) i see/know following approaches:
I decided to go for option 3 but as we are in old java, without kotlin/scala the implementation is pretty exotic as it is based on visitor pattern, ie I return
StatementCreationResult
which can be visited withStatementCreationResultMapper
. Both are abstractions and the overall solution provides:StatementCreationResult
which would force me to updateStatementCreationResultMapper
.StatementCreationResultMapper
separates logic from "delivery-mechanism" being micronaut here. So high level policy does not depend on low level policy...If it were new java/kotlin the code would be much simpler, sth like:
and in controller
Compiler will force me to handle all possible options in when statement and the code will be more straightforward