Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use macaddr rather than eui48 and bump dependencies #80

Merged
merged 2 commits into from
Mar 12, 2023
Merged

Use macaddr rather than eui48 and bump dependencies #80

merged 2 commits into from
Mar 12, 2023

Conversation

simlay
Copy link
Collaborator

@simlay simlay commented Mar 11, 2023

I ended up on this tangent because when I ran cargo check on main, I saw this warning:

warning: the following packages contain code that will be rejected by a future version of Rust: rustc-serialize v0.3.24

I felt like moving to macaddr was better than trying to fix eui48 given how old abaumhauer/eui48#34 is.

Given that part of this was to satisfy cargo audit, I decided to bump a few dependencies.

@simlay
Copy link
Collaborator Author

simlay commented Mar 11, 2023

Looks like the cargo fmt --check will fail in CI. @ewilken thoughts?

ewilken
ewilken reviewed Mar 12, 2023
View reviewed changes
Copy link
Owner

@ewilken ewilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! LGTM.

Did you test the pairing process with an actual iOS controller after this change?

I'll have a look at what's up with the CI.

@ewilken ewilken merged commit 5e3e927 into ewilken:main Mar 12, 2023
@simlay simlay deleted the use-macaddr-over-eui48 branch March 12, 2023 15:08
@simlay
Copy link
Collaborator Author

simlay commented Mar 12, 2023

Did you test the pairing process with an actual iOS controller after this change?

I just did the fan example and it worked. Any idea how this could be done in CI?

@queria queria mentioned this pull request Jul 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewilken ewilken ewilken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simlay @ewilken