Cross-compile for Scala 3 #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/play-json/src/test/scala/com/evolutiongaming/skafka/producer/JsonProducerSpec.scala
Outdated
Show resolved
Hide resolved
| } yield (a, b) | ||
| .traverseFilter { case (k, v) => | ||
| if (k != null && (keepNullValues || v != null)) (ka(k), vb(v)).mapN((_, _).some) | ||
| else none[(A, B)].pure[F] |
There was a problem hiding this comment.
Due to Scala 3 bug compiler crashed here, so I rewrote it without partial function.
There was a problem hiding this comment.
please add comment about this bug.
Pull Request Test Coverage Report for Build 6781722747
💛 - Coveralls |
Z1kkurat
reviewed
Nov 2, 2023
modules/play-json/src/test/scala/com/evolutiongaming/skafka/producer/JsonProducerSpec.scala
Outdated
Show resolved
Hide resolved
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/RebalanceCallback.scala
Outdated
Show resolved
Hide resolved
skafka/src/main/scala/com/evolutiongaming/skafka/producer/ProducerRecord.scala
Show resolved
Hide resolved
grzegorz-bielski
force-pushed
the
chore/scala3-cross-compile
branch
from
95c965e to
1951861
Compare
t3hnar
reviewed
Nov 6, 2023
skafka/src/main/scala/com/evolutiongaming/skafka/OffsetAndMetadata.scala
Show resolved
Hide resolved
|
Thanks, overall it looks nice! |
t3hnar
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated all deps (besides
kafka-clients) and cross compiled against3.3.1,2.13.12and2.12.18.TODO:
RebalanceConsumerSpec