Commit actual latest offsets on partition flow release when commitOnRevoke and flushOnRevoke are enabled #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Z1kkurat
reviewed
Oct 14, 2024
i-surkov
changed the title
Z1kkurat
reviewed
Oct 17, 2024
core/src/main/scala/com/evolutiongaming/kafka/flow/PartitionFlow.scala
Outdated
Show resolved
Hide resolved
Z1kkurat
reviewed
Oct 17, 2024
core/src/test/scala/com/evolutiongaming/kafka/flow/PartitionFlowSpec.scala
Show resolved
Hide resolved
Z1kkurat
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #256 by clearing keys cache during the partition flow release, that way giving the timer flows the opportunity to flush persistence and release held offsets before partition flow tries to perform the final commit.