Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): Remove references to deprecated modules #150

Merged
merged 7 commits into from
Feb 13, 2024
Merged

fix(docs): Remove references to deprecated modules #150

merged 7 commits into from
Feb 13, 2024

Conversation

MalteHerrmann
Copy link
Contributor

There are still a lot of references to outdated modules in the docs. This PR addresses these occurrences.

@netlify Netlify
Copy link

netlify bot commented Jan 29, 2024 •
edited
Loading

✅ Deploy Preview for dancing-hummingbird-242a98 ready!

Name Link
🔨 Latest commit 5b40fc2
🔍 Latest deploy log https://app.netlify.com/sites/dancing-hummingbird-242a98/deploys/65bb4ef1129b9b00089dfb61
😎 Deploy Preview https://deploy-preview-150--dancing-hummingbird-242a98.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MalteHerrmann MalteHerrmann marked this pull request as ready for review January 29, 2024 10:31
@MalteHerrmann
Copy link
Contributor Author

Note: The failing markdown links are expected, since the academy is down ATM but I would still keep these checked and not escape them from the markdown linter for when it is available in the future.

0xstepit
0xstepit previously requested changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@0xstepit 0xstepit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Malte!

hanchon
hanchon previously requested changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@hanchon hanchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After applying the @0xstepit changes the pr should be ready to be merged

docs/protocol/modules/inflation.md Outdated Show resolved Hide resolved
@MalteHerrmann
Copy link
Contributor Author

@0xstepit @hanchon addressed the comments, please re-review 🙏

@MalteHerrmann MalteHerrmann dismissed stale reviews from hanchon and 0xstepit February 13, 2024 09:04

addressed comments

@MalteHerrmann MalteHerrmann merged commit b5bfa39 into main Feb 13, 2024
6 of 7 checks passed
@MalteHerrmann MalteHerrmann deleted the malte/remove-outdated-modules branch February 13, 2024 09:05
@MalteHerrmann MalteHerrmann mentioned this pull request Feb 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramacarlucho ramacarlucho ramacarlucho approved these changes

@Vvaradinov Vvaradinov Vvaradinov approved these changes

@danburck danburck Awaiting requested review from danburck

@GAtom22 GAtom22 Awaiting requested review from GAtom22

@hanchon hanchon Awaiting requested review from hanchon

@0xstepit 0xstepit Awaiting requested review from 0xstepit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MalteHerrmann @hanchon @Vvaradinov @ramacarlucho @0xstepit