update cloudflare worker to serve donate-button.js with optional version param #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/p22/every-month/qtr7uh61h |
osdiab
commented
Feb 1, 2021
| @@ -205,7 +205,7 @@ You have to pass a javascript object to configure what we should display in the | |||
| You should pass this options previous initialization of the widget. Also you can change them in runtime. Example: | |||
| ```js | |||
| <script> | |||
| // Ensure that the script was fully loaded before do this | |||
| // Ensure that the script was fully loaded before do this | |||
There was a problem hiding this comment.
we can give an example of that too later!
|
I'm gonna close this, this worker is a bit too complicated and can't achieve what we want at the moment for reasons in #50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #50
Closes #56
This serves the bundle from
/donate-button.js, as specified in thecloudflare-workerREADME.mdwhich is also updated in this PR. Let me know what you think!we will need to push teh cloudflare worker after landing this (can implement #33 later); also if we bump major versions we will need to update this as well.
it also removes support for forwarding other query params; we don't use any right now so i wanted to make it a little less complicated.