Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stream info #384

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Add stream info #384

wants to merge 12 commits into from

Conversation

Mebareksaf
Copy link
Contributor

@Mebareksaf Mebareksaf commented Feb 21, 2024

Screenshot 2024-02-21 at 9 04 51 PM

@Mebareksaf Mebareksaf requested a review from gBillal February 21, 2024 20:08
@Mebareksaf Mebareksaf self-assigned this Feb 21, 2024
@gBillal
Copy link
Member

gBillal commented Feb 21, 2024

  • First don't use the back-end for this information, try subscribing to the hls events
  • Show the information on the top left of the video
  • They should be visible only if the user wants too (either add an icon on the top of the player, or use a context menu, or any other solution)

@Mebareksaf
Copy link
Contributor Author

Mebareksaf commented Feb 23, 2024

  • First don't use the back-end for this information, try subscribing to the hls events
  • Show the information on the top left of the video
  • They should be visible only if the user wants too (either add an icon on the top of the player, or use a context menu, or any other solution)
Screenshot 2024-02-23 at 4 41 43 PM

@gBillal
Copy link
Member

gBillal commented Feb 23, 2024

  • You can still put the stats higher and don't mind the timestamp.
  • Make the font smaller
  • format the bit rate into kbps, mbps, ..etc and showw the unit.
  • The bandwidth should renamed to bitrate, and try to get the actual bandwidth of the user which is his connection bandwidth.

@Mebareksaf
Copy link
Contributor Author

  • You can still put the stats higher and don't mind the timestamp.
  • Make the font smaller
  • format the bit rate into kbps, mbps, ..etc and showw the unit.
  • The bandwidth should renamed to bitrate, and try to get the actual bandwidth of the user which is his connection bandwidth.
Screenshot 2024-02-23 at 6 06 28 PM

@gBillal
Copy link
Member

gBillal commented Feb 23, 2024

  • Make the factor 1000 and not 1024
  • Show in kbps instead of mbps if the bit rate doesn't exceed 1 mbps (so 500 kbps instead of 0.5 mbps)
  • Delete the paraenthesis around the unit
  • Show a info icon in the top left of the player with appropriate opacity and hide the icon when the stats are visible.

@Mebareksaf
Copy link
Contributor Author

  • Make the factor 1000 and not 1024
  • Show in kbps instead of mbps if the bit rate doesn't exceed 1 mbps (so 500 kbps instead of 0.5 mbps)
  • Delete the paraenthesis around the unit
  • Show a info icon in the top left of the player with appropriate opacity and hide the icon when the stats are visible.

I added the icon below the snapshot button, to offer a "toggling" experience instead of hiding it when the information are available

Screenshot 2024-02-24 at 2 00 58 PM

@Mebareksaf Mebareksaf requested a review from gBillal February 27, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants