Fix withTabry for packages with dashes or periods in their name
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `withTabry` function was not working for packages with dashes or periods in their name, since it was using the package name as the name of a shell variable. This commit changes `withTabry` to first replace dashes and periods with underscores to use as the UNIQ_FN_ID name.
|
I'm not sure about the failed check... I ran locally and it passes 🤔 There are also no rust changes in the commit |
|
Yeah don't worry about the build, that's my fault, I think I fixed it in
the last commit, assuming I remember to push that.
Anyway sorry I had a comment but think I forgot to hit submit. Would it be
safer to allow list the characters instead of block listing them? Or are
you pretty sure there are no more characters in nix package names that
would pose a problem?
…On Wed, Jan 1, 2025, 13:16 Paul Gray ***@***.***> wrote:
I'm not sure about the failed check...
I ran
cargo clippy -- -D warnings
locally and it passes 🤔
There are also no rust changes in the commit
—
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFDMNF22TSSFKITJU343ZD2IRLLTAVCNFSM6AAAAABUAGAQXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRXGE2DQOJTGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
withTabryfunction was not working for packages with dashes or periods in their name, since it was using the package name as the name of a shell variable.This commit changes
withTabryto first replace dashes and periods with underscores to use as the UNIQ_FN_ID name.